Remove use of MetadataTableView in favor of utility functions #2927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2927 +/- ##
==========================================
- Coverage 60.46% 59.37% -1.1%
==========================================
Files 435 435
Lines 28434 27290 -1144
Branches 1279 1273 -6
==========================================
- Hits 17193 16203 -990
+ Misses 11241 11087 -154
Continue to review full report at Codecov.
|
hackdna
requested changes
Aug 2, 2018
refinery/data_set_manager/views.py
Outdated
| @@ -169,72 +169,65 @@ def clean(self): | |||
| "Please provide either a file or a URL") | |||
|
|
|||
|
|
|||
| class MetaDataImportView(View): | |||
| def import_by_file(_file): | |||
There was a problem hiding this comment.
Something more explicit like file_obj instead of _file?
refinery/data_set_manager/views.py
Outdated
| error_msg, | ||
| e.errno, | ||
| e.filename, | ||
| e.strerror |
There was a problem hiding this comment.
No extra line breaks necessary: error_msg, exc.errno, exc.filename, exc.strerror
refinery/data_set_manager/views.py
Outdated
| temp_file_path = os.path.join(get_temp_dir(), _file.name) | ||
| try: | ||
| _handle_uploaded_file(_file, temp_file_path) | ||
| except IOError as e: |
hackdna
approved these changes
Aug 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MetadataTableViewwas not actually aView