Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug related to missing params. #2929

Merged
merged 11 commits into from Aug 3, 2018
Merged

Conversation

jkmarx
Copy link
Member

@jkmarx jkmarx commented Aug 3, 2018

  • Fix typo
  • Add missing params

Tried using the process_isatab management command. Bugs resulted from Django 1.8 upgrade, typos and missing param declaration.

@jkmarx jkmarx requested a review from scottx611x August 3, 2018 11:58
@jkmarx jkmarx self-assigned this Aug 3, 2018
@codecov
Copy link

codecov bot commented Aug 3, 2018

Codecov Report

Merging #2929 into develop will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2929      +/-   ##
===========================================
+ Coverage    59.39%   59.41%   +0.01%     
===========================================
  Files          435      435              
  Lines        27328    27320       -8     
  Branches      1273     1273              
===========================================
  Hits         16232    16232              
+ Misses       11096    11088       -8
Impacted Files Coverage Δ
..._set_manager/management/commands/process_isatab.py 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e51e6c1...1c040d7. Read the comment docs.

@jkmarx jkmarx added this to the Release 1.6.6 milestone Aug 3, 2018
task_num += 1
sys.stdout.flush()
except:
logger.info("%s / %s: Unsuccessful parsed %s",
task_num, total, filename)
logger.info("%s / %s: Unsuccessful parsed",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsuccessfully*

@jkmarx jkmarx changed the base branch from jkmarx/fix-data-set-api-refactor to develop August 3, 2018 17:31
@jkmarx jkmarx merged commit bebec6e into develop Aug 3, 2018
@jkmarx jkmarx deleted the jkmarx/fix-process-isatab-bug branch August 3, 2018 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants