Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jkmarx/fix perms api error #2959

Merged
merged 3 commits into from Aug 29, 2018
Merged

Jkmarx/fix perms api error #2959

merged 3 commits into from Aug 29, 2018

Conversation

jkmarx
Copy link
Member

@jkmarx jkmarx commented Aug 28, 2018

Fix bug related to misunderstanding of perms, share vs add perms
@scottx611x I did confirm via locally and unit tests the perms change fixes the issue.

Resolves #2957

@jkmarx jkmarx changed the base branch from develop to release-1.6.6 August 28, 2018 18:22
@codecov
Copy link

codecov bot commented Aug 28, 2018

Codecov Report

Merging #2959 into release-1.6.6 will decrease coverage by 0.18%.
The diff coverage is 98.48%.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-1.6.6    #2959      +/-   ##
=================================================
- Coverage          59.58%   59.39%   -0.19%     
=================================================
  Files                433      433              
  Lines              27736    27197     -539     
  Branches            1274     1274              
=================================================
- Hits               16527    16155     -372     
+ Misses             11209    11042     -167
Impacted Files Coverage Δ
refinery/core/api.py 38.43% <0%> (-0.46%) ⬇️
refinery/core/test_views.py 100% <100%> (ø) ⬆️
refinery/core/views.py 42.94% <100%> (ø) ⬆️
refinery/data_set_manager/utils.py 74.77% <0%> (-0.18%) ⬇️
refinery/tool_manager/tests.py 99.82% <0%> (-0.01%) ⬇️
refinery/data_set_manager/tests.py 99.28% <0%> (ø) ⬆️
refinery/data_set_manager/search_indexes.py 94.44% <0%> (+2.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6b5665...ddcc90b. Read the comment docs.

@jkmarx jkmarx requested a review from scottx611x August 29, 2018 03:00
@@ -699,7 +699,7 @@ def get_by_db_id(self, request, **kwargs):
is_public = True

# get_owner in core models uses add to distinguish owner
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add_%s perms is used for checking ownership on non-shareable resources like analyses and workflows
data_set uses share_%s (only owners can share data_sets right now)

@jkmarx jkmarx self-assigned this Aug 29, 2018
@jkmarx jkmarx added this to the Release 1.6.6 milestone Aug 29, 2018
@jkmarx jkmarx merged commit d63e82d into release-1.6.6 Aug 29, 2018
@jkmarx jkmarx deleted the jkmarx/fix-perms-api-error branch September 17, 2018 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants