Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data set manager utils cleanup #3009

Merged
merged 6 commits into from Sep 21, 2018
Merged

Conversation

hackdna
Copy link
Member

@hackdna hackdna commented Sep 20, 2018

Remove unused functions

@hackdna hackdna added this to the Release 1.6.7 milestone Sep 20, 2018
@hackdna hackdna self-assigned this Sep 20, 2018
@hackdna hackdna added this to Backlog in Technical Debt via automation Sep 20, 2018
@codecov
Copy link

codecov bot commented Sep 20, 2018

Codecov Report

Merging #3009 into develop will decrease coverage by 0.6%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3009      +/-   ##
===========================================
- Coverage    60.14%   59.53%   -0.61%     
===========================================
  Files          433      433              
  Lines        28189    27154    -1035     
  Branches      1275     1275              
===========================================
- Hits         16953    16166     -787     
+ Misses       11236    10988     -248
Impacted Files Coverage Δ
refinery/data_set_manager/utils.py 84.28% <ø> (+1.98%) ⬆️
refinery/core/forms.py 79.41% <0%> (-5.89%) ⬇️
refinery/core/views.py 42.94% <0%> (-5.06%) ⬇️
refinery/core/models.py 75.61% <0%> (-2.11%) ⬇️
refinery/core/utils.py 37.1% <0%> (-0.38%) ⬇️
refinery/core/test_views.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a96555...407ef8b. Read the comment docs.

Copy link
Member

@scottx611x scottx611x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hackdna Looks fine to me. Not sure if the get_node_attributes* functions would be useful to @jkmarx with the FileBrowser cell editing work or not.

@jkmarx
Copy link
Member

jkmarx commented Sep 20, 2018

I'm all set and wouldn't use that method. Thanks though.

@hackdna hackdna merged commit 78b9cb8 into develop Sep 21, 2018
Technical Debt automation moved this from Backlog to Done Sep 21, 2018
@hackdna hackdna deleted the hackdna/data-set-manager-utils-cleanup branch September 21, 2018 14:49
scottx611x pushed a commit that referenced this pull request Oct 12, 2018
Remove unused get_node_attributes(), _get_node_attributes_recursion(), get_nodes(), get_matrix(), _get_parent_attributes() and _get_assay_name()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants