Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error handling when saving files directly to S3 #3021

Merged
merged 1 commit into from Sep 25, 2018

Conversation

hackdna
Copy link
Member

@hackdna hackdna commented Sep 24, 2018

No description provided.

@codecov
Copy link

codecov bot commented Sep 24, 2018

Codecov Report

Merging #3021 into develop will decrease coverage by 0.08%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3021      +/-   ##
===========================================
- Coverage     59.8%   59.71%   -0.09%     
===========================================
  Files          434      434              
  Lines        27420    27109     -311     
  Branches      1275     1275              
===========================================
- Hits         16398    16188     -210     
+ Misses       11022    10921     -101
Impacted Files Coverage Δ
refinery/data_set_manager/isa_tab_parser.py 64.95% <50%> (-1.14%) ⬇️
refinery/file_store/tasks.py 50.85% <0%> (-3.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43d0eb9...ce92f01. Read the comment docs.

@hackdna hackdna added this to In Progress in AWS S3 as a storage backend Sep 24, 2018
@hackdna hackdna merged commit dec9989 into develop Sep 25, 2018
@hackdna hackdna deleted the hackdna/s3-save-error-handling branch September 25, 2018 14:03
@sjhosui sjhosui moved this from In Progress to QA in AWS S3 as a storage backend Sep 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants