Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for tabular metadata file import to S3 failure #3022

Merged
merged 1 commit into from Sep 25, 2018
Merged

Fix for tabular metadata file import to S3 failure #3022

merged 1 commit into from Sep 25, 2018

Conversation

hackdna
Copy link
Member

@hackdna hackdna commented Sep 24, 2018 •
edited

Fix #3023

@hackdna hackdna added this to the Release 1.6.7 milestone Sep 24, 2018
@hackdna hackdna self-assigned this Sep 24, 2018
@hackdna hackdna added this to In Progress in AWS S3 as a storage backend Sep 24, 2018
@codecov
Copy link

codecov bot commented Sep 24, 2018 •
edited

Codecov Report

Merging #3022 into develop will decrease coverage by 0.09%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #3022     +/-   ##
==========================================
- Coverage     59.8%   59.71%   -0.1%     
==========================================
  Files          434      434             
  Lines        27420    27108    -312     
  Branches      1275     1275             
==========================================
- Hits         16398    16187    -211     
+ Misses       11022    10921    -101
Impacted Files Coverage Δ
refinery/file_store/tasks.py 50.85% <0%> (-3.69%) ⬇️
refinery/data_set_manager/isa_tab_parser.py 64.88% <0%> (-1.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43d0eb9...fcbb0cf. Read the comment docs.

@hackdna hackdna merged commit bd39737 into develop Sep 25, 2018
@hackdna hackdna deleted the hackdna/file-path-to-s3-bug-fix branch September 25, 2018 14:04
@sjhosui sjhosui moved this from In Progress to QA in AWS S3 as a storage backend Sep 25, 2018
scottx611x pushed a commit that referenced this pull request Oct 12, 2018
@hackdna @scottx611x
Fix for tabular metadata file import to S3 failure (#3022)
aef4a6d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottx611x scottx611x scottx611x approved these changes

Assignees

@hackdna hackdna

Labels
aws files fix-2x-small import important server
Projects
AWS S3 as a storage backend
QA
Milestone
Release 1.6.7
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hackdna @scottx611x