Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update get_file_size() to support S3 storage backend #3030

Merged
merged 1 commit into from Sep 26, 2018
Merged

Update get_file_size() to support S3 storage backend #3030

merged 1 commit into from Sep 26, 2018

Conversation

hackdna
Copy link
Member

@hackdna hackdna commented Sep 25, 2018 •
edited

Close #3029

@hackdna hackdna added this to the Release 1.6.7 milestone Sep 25, 2018
@hackdna hackdna self-assigned this Sep 25, 2018
@hackdna hackdna added this to In Progress in AWS S3 as a storage backend Sep 25, 2018
@codecov
Copy link

codecov bot commented Sep 25, 2018

Codecov Report

Merging #3030 into develop will not change coverage.
The diff coverage is 75%.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #3030   +/-   ##
=======================================
  Coverage     59.7%   59.7%           
=======================================
  Files          434     434           
  Lines        27109   27109           
  Branches      1275    1275           
=======================================
  Hits         16185   16185           
  Misses       10924   10924
Impacted Files Coverage Δ
refinery/core/models.py 75.61% <100%> (ø) ⬆️
refinery/file_store/models.py 80.89% <66.66%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd39737...c042f03. Read the comment docs.

@hackdna hackdna moved this from In Progress to QA in AWS S3 as a storage backend Sep 25, 2018
@hackdna hackdna merged commit d2c1fe9 into develop Sep 26, 2018
@hackdna hackdna deleted the hackdna/update-get-file-size branch September 26, 2018 13:41
scottx611x pushed a commit that referenced this pull request Oct 12, 2018
@hackdna @scottx611x
Update get_file_size() to support S3 storage backend (#3030)
c95f180
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottx611x scottx611x scottx611x approved these changes

Assignees

@hackdna hackdna

Labels
aws enhancement files fix-2x-small server
Projects
AWS S3 as a storage backend
QA
Milestone
Release 1.6.7
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hackdna @scottx611x