Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove generate_bam_index() #3037

Closed
wants to merge 2 commits into from
Closed

Conversation

hackdna
Copy link
Member

@hackdna hackdna commented Sep 27, 2018

Close #2713 and #2718. Toward #3025. This function was only necessary for standalone IGV which is no longer used. Also, remove related code that is no longer necessary.

…te_and_associate_auxiliary_node(), get_auxiliary_nodes(), run_generate_auxiliary_node_task() and get_auxiliary_file_generation_task_state()
Copy link
Member

@scottx611x scottx611x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This functionality provided by generate_bam_index is still being utilized by our current IGV Vis tool

@hackdna
Copy link
Member Author

hackdna commented Sep 27, 2018

So the comment in generate_bam_index() is incorrect?

@scottx611x
Copy link
Member

@hackdna No, it should still be refactored/rewritten Ref #2718. When that code was introduced we only had Standalone IGV implemented.

@hackdna
Copy link
Member Author

hackdna commented Sep 27, 2018

Strange, "standalone" implies that it would not be needed with a different type of IGV.

@hackdna hackdna closed this Sep 27, 2018
Technical Debt automation moved this from Backlog to Done Sep 27, 2018
@hackdna hackdna deleted the hackdna/remove-generate-bam-index branch September 27, 2018 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants