Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rename_datafile() #3040

Merged
merged 4 commits into from Oct 2, 2018
Merged

Update rename_datafile() #3040

merged 4 commits into from Oct 2, 2018

Conversation

hackdna
Copy link
Member

@hackdna hackdna commented Oct 1, 2018

Close #3027

@hackdna hackdna added this to the Release 1.6.7 milestone Oct 1, 2018
@hackdna hackdna self-assigned this Oct 1, 2018
@codecov
Copy link

codecov bot commented Oct 1, 2018 •
edited

Codecov Report

Merging #3040 into develop will decrease coverage by 1.49%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #3040     +/-   ##
==========================================
- Coverage    61.16%   59.66%   -1.5%     
==========================================
  Files          433      433             
  Lines        28467    27034   -1433     
  Branches      1288     1275     -13     
==========================================
- Hits         17413    16131   -1282     
+ Misses       11054    10903    -151
Impacted Files Coverage Δ
refinery/file_store/utils.py 51.57% <100%> (ø) ⬆️
refinery/analysis_manager/tasks.py 74.18% <100%> (-0.94%) ⬇️
refinery/file_store/models.py 78.88% <13.04%> (-3.48%) ⬇️
refinery/data_set_manager/views.py 60.2% <0%> (-6.54%) ⬇️
refinery/factory_boy/utils.py 98.46% <0%> (-1.14%) ⬇️
refinery/ui/source/js/file-browser/ctrls/ctrl.js 30.39% <0%> (-0.38%) ⬇️
refinery/data_set_manager/test_views.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c313a98...73680c1. Read the comment docs.

@hackdna hackdna added this to In Progress in AWS S3 as a storage backend Oct 1, 2018
@hackdna hackdna moved this from In Progress to QA in AWS S3 as a storage backend Oct 1, 2018
@hackdna hackdna merged commit 587fb66 into develop Oct 2, 2018
@hackdna hackdna deleted the hackdna/update-rename-datafile branch October 2, 2018 15:03
scottx611x pushed a commit that referenced this pull request Oct 12, 2018
@hackdna @scottx611x
Update rename_datafile() (#3040)
bec1862 
* Update rename_datafile() to support S3 storage backend
* Remove _rename_file_on_disk()
* Switch to Celery logger in analysis_manager tasks
* Add a default value for progress_report callable arg
@jkmarx jkmarx mentioned this pull request Sep 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottx611x scottx611x scottx611x approved these changes

Assignees

@hackdna hackdna

Labels
aws enhancement files fix-4x-medium server
Projects
AWS S3 as a storage backend
QA
Milestone
Release 1.6.7
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hackdna @scottx611x