Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update error handling for file operations #3041

Merged
merged 1 commit into from Oct 2, 2018

Conversation

hackdna
Copy link
Member

@hackdna hackdna commented Oct 1, 2018

In get_file_size() and delete_datafile()

@hackdna hackdna added this to the Release 1.6.7 milestone Oct 1, 2018
@hackdna hackdna self-assigned this Oct 1, 2018
@hackdna hackdna added this to In Progress in AWS S3 as a storage backend Oct 1, 2018
@hackdna hackdna moved this from In Progress to QA in AWS S3 as a storage backend Oct 1, 2018
@codecov
Copy link

codecov bot commented Oct 1, 2018

Codecov Report

Merging #3041 into develop will decrease coverage by 1.51%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3041      +/-   ##
===========================================
- Coverage    61.19%   59.68%   -1.52%     
===========================================
  Files          433      433              
  Lines        28478    27032    -1446     
  Branches      1288     1275      -13     
===========================================
- Hits         17428    16134    -1294     
+ Misses       11050    10898     -152
Impacted Files Coverage Δ
refinery/file_store/models.py 81.87% <0%> (-3.25%) ⬇️
refinery/data_set_manager/views.py 60.2% <0%> (-6.54%) ⬇️
refinery/factory_boy/utils.py 98.46% <0%> (-1.14%) ⬇️
refinery/analysis_manager/tasks.py 74.08% <0%> (-1.04%) ⬇️
refinery/ui/source/js/file-browser/ctrls/ctrl.js 30.39% <0%> (-0.38%) ⬇️
refinery/data_set_manager/test_views.py 100% <0%> (ø) ⬆️
refinery/file_store/utils.py 51.57% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c313a98...b5c7b9d. Read the comment docs.

@hackdna hackdna merged commit beefa5b into develop Oct 2, 2018
@hackdna hackdna deleted the hackdna/update-file-error-handling branch October 2, 2018 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants