Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versions of installation prerequisites #3069

Merged
merged 2 commits into from Nov 2, 2018
Merged

Conversation

hackdna
Copy link
Member

@hackdna hackdna commented Oct 24, 2018

No description provided.

@codecov
Copy link

codecov bot commented Oct 24, 2018

Codecov Report

Merging #3069 into develop will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3069      +/-   ##
===========================================
- Coverage    60.45%   60.38%   -0.07%     
===========================================
  Files          434      434              
  Lines        27532    27460      -72     
  Branches      1292     1276      -16     
===========================================
- Hits         16644    16582      -62     
+ Misses       10888    10878      -10
Impacted Files Coverage Δ
...nery/ui/source/js/file-browser/services/factory.js 64.12% <0%> (-7.8%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c133c3b...b41edb1. Read the comment docs.

Copy link
Member

@scottx611x scottx611x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we specify git 2.19.0 if we're targeting the latest current releases here?

@hackdna
Copy link
Member Author

hackdna commented Oct 24, 2018

2.17.1 is the version of git that comes with OS X 10.13.6 and the one I have tested with. If you can confirm that v2.19.0 works then I can update the PR.

@scottx611x
Copy link
Member

@hackdna I've been using git v2.19.0 for the past 5 days and haven't had any issues

@hackdna hackdna merged commit b85682d into develop Nov 2, 2018
Technical Debt automation moved this from Backlog to Done Nov 2, 2018
@hackdna hackdna deleted the hackdna/readme-update branch November 2, 2018 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants