Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scottx611x/handle admin users specially when determining ownership #3080

Conversation

scottx611x
Copy link
Member

@scottx611x scottx611x commented Nov 1, 2018

get_owner() doesn't have great performance, so only use it when we have to i.e. when the requester is a superuser

@codecov
Copy link

codecov bot commented Nov 1, 2018

Codecov Report

Merging #3080 into develop will decrease coverage by 0.09%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #3080     +/-   ##
==========================================
- Coverage    60.63%   60.53%   -0.1%     
==========================================
  Files          434      434             
  Lines        28074    27620    -454     
  Branches      1281     1281             
==========================================
- Hits         17022    16721    -301     
+ Misses       11052    10899    -153
Impacted Files Coverage Δ
refinery/core/api.py 38.29% <0%> (-1.18%) ⬇️
refinery/core/test_views.py 100% <100%> (ø) ⬆️
refinery/core/views.py 47.01% <66.66%> (-7.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 722bc26...cd99320. Read the comment docs.

Copy link
Member

@jkmarx jkmarx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks.

@jkmarx jkmarx merged commit eedf457 into develop Nov 2, 2018
@jkmarx jkmarx deleted the scottx611x/handle_admin_users_specially_when_determining_ownership branch November 2, 2018 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants