Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hackna/s3 backup #3125

Merged
merged 4 commits into from Dec 4, 2018
Merged

Hackna/s3 backup #3125

merged 4 commits into from Dec 4, 2018

Conversation

hackdna
Copy link
Member

@hackdna hackdna commented Dec 3, 2018

Close #3042

@codecov
Copy link

codecov bot commented Dec 3, 2018

Codecov Report

Merging #3125 into develop will decrease coverage by 1.08%.
The diff coverage is 40%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3125      +/-   ##
===========================================
- Coverage    62.06%   60.97%   -1.09%     
===========================================
  Files          435      421      -14     
  Lines        28335    27372     -963     
  Branches      1274     1264      -10     
===========================================
- Hits         17587    16691     -896     
+ Misses       10748    10681      -67
Impacted Files Coverage Δ
refinery/file_store/utils.py 51.21% <40%> (-2.5%) ⬇️
...file-browser/ctrls/user-file-browser-files-ctrl.js 9.37% <0%> (-29.23%) ⬇️
refinery/data_set_manager/isa_tab_parser.py 64.95% <0%> (-8.72%) ⬇️
refinery/ui/source/js/file-browser/ctrls/ctrl.js 30.95% <0%> (-4.95%) ⬇️
refinery/data_set_manager/models.py 83.44% <0%> (-2.98%) ⬇️
refinery/data_set_manager/utils.py 83.87% <0%> (-1.74%) ⬇️
refinery/core/models.py 78.29% <0%> (-0.98%) ⬇️
refinery/core/views.py 47.61% <0%> (-0.89%) ⬇️
refinery/user_files_manager/views.py 97.56% <0%> (-0.44%) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb957f8...ac01f3d. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Dec 3, 2018

Codecov Report

Merging #3125 into develop will decrease coverage by 1.08%.
The diff coverage is 40%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3125      +/-   ##
===========================================
- Coverage    62.06%   60.97%   -1.09%     
===========================================
  Files          435      421      -14     
  Lines        28335    27372     -963     
  Branches      1274     1264      -10     
===========================================
- Hits         17587    16691     -896     
+ Misses       10748    10681      -67
Impacted Files Coverage Δ
refinery/file_store/utils.py 51.21% <40%> (-2.5%) ⬇️
...file-browser/ctrls/user-file-browser-files-ctrl.js 9.37% <0%> (-29.23%) ⬇️
refinery/data_set_manager/isa_tab_parser.py 64.95% <0%> (-8.72%) ⬇️
refinery/ui/source/js/file-browser/ctrls/ctrl.js 30.95% <0%> (-4.95%) ⬇️
refinery/data_set_manager/models.py 83.44% <0%> (-2.98%) ⬇️
refinery/data_set_manager/utils.py 83.87% <0%> (-1.74%) ⬇️
refinery/core/models.py 78.29% <0%> (-0.98%) ⬇️
refinery/core/views.py 47.61% <0%> (-0.89%) ⬇️
refinery/user_files_manager/views.py 97.56% <0%> (-0.44%) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb957f8...ac01f3d. Read the comment docs.

@hackdna hackdna added this to In Progress in AWS S3 as a storage backend Dec 3, 2018
@hackdna hackdna merged commit 83d8831 into develop Dec 4, 2018
@hackdna hackdna deleted the hackna/s3-backup branch December 4, 2018 17:09
@hackdna hackdna moved this from In Progress to QA in AWS S3 as a storage backend Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants