Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add buttons. #3128

Merged
merged 2 commits into from Dec 5, 2018
Merged

Add buttons. #3128

merged 2 commits into from Dec 5, 2018

Conversation

jkmarx
Copy link
Member

@jkmarx jkmarx commented Dec 4, 2018

Ref # 3127

  • Update buttons to show only icons.
  • Color, blue

screen shot 2018-12-04 at 2 02 44 pm

@codecov
Copy link

codecov bot commented Dec 4, 2018

Codecov Report

Merging #3128 into develop will decrease coverage by 0.78%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3128      +/-   ##
===========================================
- Coverage    62.06%   61.28%   -0.79%     
===========================================
  Files          437      434       -3     
  Lines        28436    27589     -847     
  Branches      1283     1274       -9     
===========================================
- Hits         17649    16908     -741     
+ Misses       10787    10681     -106
Impacted Files Coverage Δ
refinery/data_set_manager/isa_tab_parser.py 64.95% <0%> (-8.72%) ⬇️
refinery/data_set_manager/models.py 83.44% <0%> (-2.98%) ⬇️
refinery/file_store/utils.py 51.57% <0%> (-2.14%) ⬇️
refinery/data_set_manager/utils.py 83.87% <0%> (-1.74%) ⬇️
refinery/core/models.py 78.36% <0%> (-0.9%) ⬇️
...ry/ui/source/js/dashboard/controllers/dashboard.js 9.26% <0%> (-0.16%) ⬇️
...rce/js/commons/directives/analysis-delete-modal.js
refinery/data_set_manager/test_utils.py
...rce/js/commons/ctrls/analysis-delete-modal-ctrl.js
...finery/ui/source/js/analysis-monitor/ctrls/ctrl.js 70% <0%> (+0.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb957f8...37fdb79. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 4, 2018

Codecov Report

Merging #3128 into develop will decrease coverage by 0.78%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3128      +/-   ##
===========================================
- Coverage    62.06%   61.28%   -0.79%     
===========================================
  Files          437      434       -3     
  Lines        28436    27589     -847     
  Branches      1283     1274       -9     
===========================================
- Hits         17649    16908     -741     
+ Misses       10787    10681     -106
Impacted Files Coverage Δ
refinery/data_set_manager/isa_tab_parser.py 64.95% <0%> (-8.72%) ⬇️
refinery/data_set_manager/models.py 83.44% <0%> (-2.98%) ⬇️
refinery/file_store/utils.py 51.57% <0%> (-2.14%) ⬇️
refinery/data_set_manager/utils.py 83.87% <0%> (-1.74%) ⬇️
refinery/core/models.py 78.36% <0%> (-0.9%) ⬇️
...ry/ui/source/js/dashboard/controllers/dashboard.js 9.26% <0%> (-0.16%) ⬇️
...rce/js/commons/directives/analysis-delete-modal.js
refinery/data_set_manager/test_utils.py
...rce/js/commons/ctrls/analysis-delete-modal-ctrl.js
...finery/ui/source/js/analysis-monitor/ctrls/ctrl.js 70% <0%> (+0.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb957f8...bdfc49a. Read the comment docs.

@jkmarx jkmarx self-assigned this Dec 4, 2018
@jkmarx jkmarx added this to the Release 1.6.8 milestone Dec 4, 2018
@jkmarx jkmarx merged commit 179a796 into develop Dec 5, 2018
@jkmarx jkmarx deleted the jkamrx/update-vis-button branch December 5, 2018 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants