Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve bug due to incorrect name reference. #3143

Merged
merged 1 commit into from Dec 18, 2018

Conversation

jkmarx
Copy link
Member

@jkmarx jkmarx commented Dec 14, 2018

  • Fix landing page selection bug.
  • Update default to technology

@jkmarx jkmarx self-assigned this Dec 14, 2018
@jkmarx jkmarx added this to the Release 1.6.8 milestone Dec 14, 2018
@codecov
Copy link

codecov bot commented Dec 14, 2018

Codecov Report

Merging #3143 into develop will increase coverage by 0.06%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3143      +/-   ##
===========================================
+ Coverage    61.27%   61.34%   +0.06%     
===========================================
  Files          440      436       -4     
  Lines        27699    27618      -81     
  Branches      1280     1277       -3     
===========================================
- Hits         16972    16941      -31     
+ Misses       10727    10677      -50
Impacted Files Coverage Δ
...ery/ui/source/js/home/ctrls/data-set-chart-ctrl.js 61.9% <0%> (ø) ⬆️
refinery/ui/source/js/home/ctrls/home-ctrl.js 100% <0%> (ø) ⬆️
...ery/ui/source/js/home/directives/video-carousel.js
...inery/ui/source/js/home/ctrls/twitter-feed-ctrl.js
...inery/ui/source/js/home/directives/twitter-feed.js
...finery/file_store/management/commands/ebs_to_s3.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9738fa3...04b2318. Read the comment docs.

@jkmarx jkmarx merged commit d0cb1cf into develop Dec 18, 2018
@jkmarx jkmarx deleted the jkmarx/home-chart-select-bug branch December 18, 2018 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants