Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update navbar in template. #3151

Merged
merged 2 commits into from Jan 4, 2019
Merged

Conversation

jkmarx
Copy link
Member

@jkmarx jkmarx commented Jan 3, 2019

screen shot 2019-01-03 at 1 10 45 pm
Ref #2680

@jkmarx jkmarx requested a review from scottx611x January 3, 2019 18:23
@jkmarx jkmarx self-assigned this Jan 3, 2019
@jkmarx jkmarx added this to the Release 1.6.8 milestone Jan 3, 2019
@codecov
Copy link

codecov bot commented Jan 3, 2019

Codecov Report

Merging #3151 into develop will decrease coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3151      +/-   ##
===========================================
- Coverage     61.5%   61.27%   -0.24%     
===========================================
  Files          444      440       -4     
  Lines        28031    27699     -332     
  Branches      1298     1280      -18     
===========================================
- Hits         17240    16972     -268     
+ Misses       10791    10727      -64
Impacted Files Coverage Δ
.../ui/source/js/data-set-about/ctrls/sharing-ctrl.js 52.17% <0%> (-5.9%) ⬇️
...dashboard/controllers/primary-group-button-ctrl.js 91.66% <0%> (-3.17%) ⬇️
.../ui/source/js/data-set-about/ctrls/details-ctrl.js 42.46% <0%> (-2.44%) ⬇️
refinery/core/views.py 48.5% <0%> (-2.21%) ⬇️
refinery/ui/source/js/refinery-controller.js 7.89% <0%> (-0.86%) ⬇️
refinery/core/models.py 78.36% <0%> (-0.09%) ⬇️
refinery/core/test_views.py 100% <0%> (ø) ⬆️
refinery/core/urls.py 100% <0%> (ø) ⬆️
...nery/ui/source/js/commons/services/current-user.js
...source/js/main-nav-bar/ctrls/main-nav-bar-ctrls.js
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f9d144...4629509. Read the comment docs.

@jkmarx jkmarx merged commit d46b620 into develop Jan 4, 2019
@jkmarx jkmarx deleted the jkmarx/update-navbar-in-template branch January 4, 2019 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants