Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify and make file extension handling more robust #3155

Merged
merged 1 commit into from Jan 10, 2019

Conversation

hackdna
Copy link
Member

@hackdna hackdna commented Jan 4, 2019

No description provided.

@codecov
Copy link

codecov bot commented Jan 4, 2019

Codecov Report

Merging #3155 into develop will decrease coverage by 0.36%.
The diff coverage is 93.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3155      +/-   ##
===========================================
- Coverage    61.64%   61.27%   -0.37%     
===========================================
  Files          440      440              
  Lines        27981    27695     -286     
  Branches      1281     1280       -1     
===========================================
- Hits         17248    16970     -278     
+ Misses       10733    10725       -8
Impacted Files Coverage Δ
refinery/file_store/test_models.py 100% <100%> (ø) ⬆️
refinery/file_store/models.py 79.48% <81.81%> (-5.56%) ⬇️
refinery/file_store/utils.py 51.21% <0%> (-13.79%) ⬇️
refinery/file_store/tasks.py 51.13% <0%> (-12.67%) ⬇️
...ce/js/dashboard/controllers/data-sets-card-ctrl.js 69.02% <0%> (-1.06%) ⬇️
...urce/js/dashboard/controllers/history-card-ctrl.js 92% <0%> (-0.31%) ⬇️
...ce/js/dashboard/controllers/dashboard-main-ctrl.js 95.83% <0%> (-0.17%) ⬇️
refinery/core/views.py 48.5% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 771c8dd...f3637cf. Read the comment docs.

@hackdna hackdna merged commit 29ffb14 into develop Jan 10, 2019
@hackdna hackdna deleted the hackdna/file-extensions branch January 10, 2019 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants