Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove get_temp_dir() #3178

Merged
merged 1 commit into from Jan 17, 2019
Merged

Remove get_temp_dir() #3178

merged 1 commit into from Jan 17, 2019

Conversation

hackdna
Copy link
Member

@hackdna hackdna commented Jan 17, 2019

Close #3028. Also, remove FILE_STORE_TEMP_DIR and FILE_UPLOAD_TEMP_DIR Django settings. Toward #3052.

@codecov
Copy link

codecov bot commented Jan 17, 2019

Codecov Report

Merging #3178 into develop will decrease coverage by 0.19%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #3178     +/-   ##
==========================================
- Coverage    61.98%   61.79%   -0.2%     
==========================================
  Files          438      438             
  Lines        27784    27493    -291     
  Branches      1285     1285             
==========================================
- Hits         17222    16989    -233     
+ Misses       10562    10504     -58
Impacted Files Coverage Δ
refinery/file_store/test_models.py 100% <ø> (ø) ⬆️
refinery/file_store/models.py 79.22% <ø> (-3.84%) ⬇️
refinery/file_store/tasks.py 58.37% <66.66%> (-1.69%) ⬇️
refinery/data_set_manager/views.py 62.1% <80%> (-0.25%) ⬇️
refinery/file_store/utils.py 68.93% <0%> (-0.05%) ⬇️
refinery/tool_manager/tests.py 99.77% <0%> (-0.01%) ⬇️
refinery/tool_manager/utils.py 100% <0%> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed06413...4c85f6b. Read the comment docs.

@hackdna hackdna merged commit dbb1848 into develop Jan 17, 2019
@hackdna hackdna deleted the hackdna/remove-get-temp-dir branch January 17, 2019 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants