Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add site-profile api service. #3181

Merged
merged 2 commits into from Jan 25, 2019
Merged

Add site-profile api service. #3181

merged 2 commits into from Jan 25, 2019

Conversation

jkmarx
Copy link
Member

@jkmarx jkmarx commented Jan 25, 2019

@jkmarx jkmarx self-assigned this Jan 25, 2019
@jkmarx jkmarx added this to the Release 1.6.8 milestone Jan 25, 2019
@codecov
Copy link

codecov bot commented Jan 25, 2019

Codecov Report

Merging #3181 into develop will decrease coverage by 2.56%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #3181      +/-   ##
==========================================
- Coverage    64.37%   61.8%   -2.57%     
==========================================
  Files          440     439       -1     
  Lines        30508   27502    -3006     
  Branches      1285    1285              
==========================================
- Hits         19638   16998    -2640     
+ Misses       10870   10504     -366
Impacted Files Coverage Δ
...source/js/commons/services/site-profile-service.js 100% <100%> (ø) ⬆️
refinery/data_set_manager/isa_tab_parser.py 64.95% <0%> (-7.81%) ⬇️
refinery/core/views.py 48.5% <0%> (-6.58%) ⬇️
refinery/data_set_manager/utils.py 83.87% <0%> (-3.81%) ⬇️
refinery/data_set_manager/views.py 62.1% <0%> (-3.74%) ⬇️
refinery/core/models.py 78.36% <0%> (-1.36%) ⬇️
refinery/core/utils.py 40% <0%> (-1.32%) ⬇️
refinery/data_set_manager/models.py 83.44% <0%> (-1.29%) ⬇️
refinery/core/admin.py 84.94% <0%> (-0.77%) ⬇️
refinery/data_set_manager/tests.py 99.32% <0%> (-0.06%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a574e4...c43f9f5. Read the comment docs.

@jkmarx jkmarx merged commit 49d3bc3 into develop Jan 25, 2019
@jkmarx jkmarx deleted the jkmarx/add-config-service-ui branch January 25, 2019 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants