Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix firefox issue due to capturing events within button element. #3185

Merged
merged 1 commit into from Jan 30, 2019

Conversation

jkmarx
Copy link
Member

@jkmarx jkmarx commented Jan 29, 2019

@hackdna I read comments about firefox having issues capturing events within button elements. Updating to a div fixed it locally without spending too much time on it.

Ref: #3173

@jkmarx jkmarx requested a review from hackdna January 29, 2019 20:26
@jkmarx jkmarx self-assigned this Jan 29, 2019
@jkmarx jkmarx added this to the Release 1.6.8 milestone Jan 29, 2019
@codecov
Copy link

codecov bot commented Jan 29, 2019

Codecov Report

Merging #3185 into develop will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3185      +/-   ##
===========================================
- Coverage    62.02%   61.98%   -0.05%     
===========================================
  Files          440      439       -1     
  Lines        27737    27683      -54     
  Branches      1289     1285       -4     
===========================================
- Hits         17205    17160      -45     
+ Misses       10532    10523       -9
Impacted Files Coverage Δ
refinery/ui/source/js/home/ctrls/home-ctrl.js 75% <0%> (-12.88%) ⬇️
...ery/ui/source/js/home/ctrls/data-set-chart-ctrl.js 61.9% <0%> (-0.17%) ⬇️
...ery/ui/source/js/home/directives/video-carousel.js 52.94% <0%> (-0.13%) ⬇️
...inery/ui/source/js/home/ctrls/twitter-feed-ctrl.js 100% <0%> (ø) ⬆️
.../ui/source/js/home/services/home-config-service.js

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c31b5c...34aed5c. Read the comment docs.

Copy link
Member

@hackdna hackdna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this actually makes more sense since form input of file type is already a button.

@jkmarx jkmarx merged commit 7c297a4 into develop Jan 30, 2019
@jkmarx jkmarx deleted the jkmarx/add-files-firefox-bug branch January 30, 2019 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants