Jkmarx/fix dashboard search bugs #3202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #3202 +/- ##
===========================================
- Coverage 62.7% 62.15% -0.55%
===========================================
Files 440 440
Lines 28432 27774 -658
Branches 1288 1282 -6
===========================================
- Hits 17829 17264 -565
+ Misses 10603 10510 -93
Continue to review full report at Codecov.
|
scottx611x
reviewed
Feb 7, 2019
| if (query && query.length > 1) { | ||
| vm.loadingDataSets = true; | ||
| var apiRequest = new DataSetSearchApi(query); | ||
| apiRequest(200).then(function (response) { | ||
| apiRequest(100).then(function (response) { |
There was a problem hiding this comment.
Not understanding the need for a 100 instead of a 200 here
There was a problem hiding this comment.
Oops, good catch. It's the number of ds returned.
scottx611x
approved these changes
Feb 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2967
Also fixes this new bug with highlight
Fixed:
