Jkmarx/avoid duplicate api calls #3204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkmarx
commented
Feb 8, 2019
|
|
||
| var promise = $q.defer(); |
There was a problem hiding this comment.
- Wrapped service call in a function per style guide and testability.
- Reordered function per style guide.
jkmarx
commented
Feb 8, 2019
| vm.gridOptions.onRegisterApi = function (api) { | ||
| api.core.on.sortChanged(null, vm.sortChanged); | ||
| }; | ||
|
|
||
| /** |
There was a problem hiding this comment.
Code kept in tack minus function wrapper.
jkmarx
commented
Feb 8, 2019
| }, function () { | ||
| $log.error('/files/ request failed'); | ||
| promise.reject(); | ||
| /* |
There was a problem hiding this comment.
- Avoid duplicate api call and watch added factory variable, which is updated when files-ctrl calls api for the grid data.
jkmarx
commented
Feb 8, 2019
| @@ -1,12 +0,0 @@ | |||
| (function () { | |||
Codecov Report
@@ Coverage Diff @@
## develop #3204 +/- ##
==========================================
- Coverage 63.82% 62.23% -1.6%
==========================================
Files 441 439 -2
Lines 30060 27766 -2294
Branches 1295 1282 -13
==========================================
- Hits 19186 17279 -1907
+ Misses 10874 10487 -387
Continue to review full report at Codecov.
|
scottx611x
approved these changes
Feb 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2006