Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hackdna/puppet params #3208

Merged
merged 13 commits into from Feb 14, 2019
Merged

Hackdna/puppet params #3208

merged 13 commits into from Feb 14, 2019

Conversation

hackdna
Copy link
Member

@hackdna hackdna commented Feb 13, 2019

Toward #3052, #822 and #2743:

  • centralize Refinery Puppet module configuration in class refinery::params
  • parametrize all Refinery Puppet module classes to avoid use of globals
  • consolidate vagrant.pp and aws.pp into site.pp manifest
  • factor out Django and UI configuration into separate classes
  • remove refinery::aws class
  • simplify refinery::neo4j and refinery::solr classes

@codecov
Copy link

codecov bot commented Feb 13, 2019

Codecov Report

Merging #3208 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3208   +/-   ##
========================================
  Coverage    62.26%   62.26%           
========================================
  Files          439      439           
  Lines        27764    27764           
  Branches      1282     1282           
========================================
  Hits         17286    17286           
  Misses       10478    10478

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31a9598...aa25fc9. Read the comment docs.

@hackdna hackdna merged commit 928b624 into develop Feb 14, 2019
Technical Debt automation moved this from Backlog to Done Feb 14, 2019
@hackdna hackdna deleted the hackdna/puppet-params branch February 14, 2019 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants