Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jkmarx/fix position of text #3233

Merged
merged 3 commits into from Feb 27, 2019
Merged

Jkmarx/fix position of text #3233

merged 3 commits into from Feb 27, 2019

Conversation

jkmarx
Copy link
Member

@jkmarx jkmarx commented Feb 27, 2019

Resolves #3232 but reopens #3222

Conflict with ui-select library css making it difficult to customize the label.

jkmarx and others added 3 commits February 25, 2019 10:57
@jkmarx jkmarx self-assigned this Feb 27, 2019
@jkmarx jkmarx added this to the Release 1.6.8 milestone Feb 27, 2019
@codecov
Copy link

codecov bot commented Feb 27, 2019

Codecov Report

Merging #3233 into develop will not change coverage.
The diff coverage is 75%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3233   +/-   ##
========================================
  Coverage    62.28%   62.28%           
========================================
  Files          439      439           
  Lines        27774    27774           
  Branches      1283     1283           
========================================
  Hits         17300    17300           
  Misses       10474    10474
Impacted Files Coverage Δ
...urce/js/data-set-import/controllers/file-upload.js 27.77% <0%> (ø) ⬆️
...ce/js/data-set-import/directives/metadata-table.js 68% <100%> (ø) ⬆️
...e/js/data-set-import/controllers/file-upload-s3.js 70% <60%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49f16d2...2f32ebc. Read the comment docs.

@jkmarx jkmarx merged commit dda3bd6 into develop Feb 27, 2019
jkmarx added a commit that referenced this pull request Feb 27, 2019
jkmarx added a commit that referenced this pull request Feb 27, 2019
jkmarx added a commit that referenced this pull request Feb 27, 2019
@jkmarx jkmarx deleted the jkmarx/fix-position-of-text branch February 27, 2019 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant