Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove protocol resource which is not used by client. #3253

Merged
merged 4 commits into from Mar 12, 2019

Conversation

jkmarx
Copy link
Member

@jkmarx jkmarx commented Mar 11, 2019

Ref #2618

  • Protocol Resource currently not used by client since Satori was removed.
    In the future, we may need to add an API to support dashboard enhancements, Ref Dashboard Enhance DS Details #3250

@jkmarx jkmarx self-assigned this Mar 11, 2019
@jkmarx jkmarx added this to the Release 1.6.9 milestone Mar 11, 2019
@codecov
Copy link

codecov bot commented Mar 11, 2019

Codecov Report

Merging #3253 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #3253   +/-   ##
=======================================
  Coverage     66.9%   66.9%           
=======================================
  Files          384     384           
  Lines        24283   24283           
  Branches       854     854           
=======================================
  Hits         16247   16247           
  Misses        8036    8036
Impacted Files Coverage Δ
refinery/data_set_manager/api.py 93.33% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec0b7fc...292be91. Read the comment docs.

@jkmarx jkmarx requested a review from hackdna March 11, 2019 17:49
@hackdna hackdna added this to Backlog in Technical Debt via automation Mar 11, 2019
@jkmarx jkmarx merged commit 7827c47 into develop Mar 12, 2019
Technical Debt automation moved this from Backlog to Done Mar 12, 2019
@jkmarx jkmarx deleted the jkmarx/remove-protocol-api branch March 12, 2019 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants