Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jkmarx/remove workflow api v1 #3263

Merged
merged 3 commits into from Mar 19, 2019
Merged

Jkmarx/remove workflow api v1 #3263

merged 3 commits into from Mar 19, 2019

Conversation

jkmarx
Copy link
Member

@jkmarx jkmarx commented Mar 18, 2019 •
edited

Ref #2618

  • Remove workflow api v1 (was not used, since workflow v2 already existed)

@jkmarx jkmarx self-assigned this Mar 18, 2019
@jkmarx jkmarx added this to the Release 1.6.9 milestone Mar 18, 2019
@codecov
Copy link

codecov bot commented Mar 18, 2019 •
edited

Codecov Report

Merging #3263 into develop will increase coverage by 2.09%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3263      +/-   ##
===========================================
+ Coverage    65.15%   67.25%   +2.09%     
===========================================
  Files          383      380       -3     
  Lines        25749    24333    -1416     
  Branches       946      852      -94     
===========================================
- Hits         16778    16364     -414     
+ Misses        8971     7969    -1002
Impacted Files Coverage Δ
refinery/core/api.py 38.77% <ø> (-2.29%) ⬇️
refinery/core/urls.py 100% <ø> (ø) ⬆️
refinery/core/views.py 54.32% <100%> (-2.38%) ⬇️
refinery/core/forms.py 83.33% <100%> (-1.97%) ⬇️
...ui/source/js/workflow/directives/workflow-graph.js
refinery/ui/source/js/workflow/ctrl.js
refinery/ui/source/js/workflow/module.js

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1de1d1d...dc8a026. Read the comment docs.

@jkmarx jkmarx requested a review from hackdna March 18, 2019 14:54
@jkmarx
Jkmarx/remove unused workflow views (#3264)
dc8a026 
* Remove unused views and forms.

* Remove old unused helper method for workflows.

* Remove unused url.
@jkmarx jkmarx merged commit 1a671b1 into develop Mar 19, 2019
@jkmarx jkmarx deleted the jkmarx/remove-workflow-api-v1 branch March 19, 2019 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hackdna hackdna hackdna approved these changes

Assignees

@jkmarx jkmarx

Labels
api technical debt workflow
Projects
None yet
Milestone
Release 1.6.9
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jkmarx @hackdna