Jkmarx/groups api v2 #3265
Jkmarx/groups api v2 #3265
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3265 +/- ##
===========================================
- Coverage 66.66% 65.55% -1.12%
===========================================
Files 386 383 -3
Lines 26659 25277 -1382
Branches 976 947 -29
===========================================
- Hits 17773 16570 -1203
+ Misses 8886 8707 -179
Continue to review full report at Codecov.
|
| @@ -1,142 +1,145 @@ | |||
| 'use strict'; | |||
| /** | |||
There was a problem hiding this comment.
reorganized to meet style guide and use new api
| @@ -0,0 +1,45 @@ | |||
| /** | |||
There was a problem hiding this comment.
Switched over the share_component to group_perms_component name, due to new apis.
| @@ -468,7 +468,33 @@ <h3>Data Files</h3> | |||
| </span> | |||
| </p> | |||
|
|
|||
| <rp-data-set-about-sharing></rp-data-set-about-sharing> | |||
| <div class="refinery-header"> | |||
There was a problem hiding this comment.
Now returned from data_set v2 api so moved into details component
refinery/core/test_views.py
Outdated
| self.data_set.share(self.group) | ||
| self.data_set.share(self.group_2) | ||
|
|
||
| def test_get_groups_with_ds_uuid_returns_401_for_anon(self): |
There was a problem hiding this comment.
I'd expand ds to dataset to make it more explicit (here and below).
refinery/core/test_views.py
Outdated
| def setUp(self): | ||
| super(GroupApiV2Tests, self).setUp( | ||
| api_base_name="groups/", | ||
| view=GroupViewSet.as_view({'get': 'list'}) |
There was a problem hiding this comment.
These two could fit on one line?
Ref #2618
Can't remove data set resource until we extend group api v2 to include patch for updating perms.