Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to match style guide for params for analysis view set #3337

Merged
merged 1 commit into from Apr 23, 2019

Conversation

jkmarx
Copy link
Member

@jkmarx jkmarx commented Apr 23, 2019

@jkmarx jkmarx added this to the Release 1.6.9 milestone Apr 23, 2019
@jkmarx jkmarx self-assigned this Apr 23, 2019
@jkmarx jkmarx changed the title Update to match style guide for params. Update to match style guide for params for analysis view set Apr 23, 2019
@jkmarx jkmarx requested a review from hackdna April 23, 2019 01:59
@codecov
Copy link

codecov bot commented Apr 23, 2019

Codecov Report

Merging #3337 into develop will increase coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3337      +/-   ##
===========================================
+ Coverage    68.39%   68.54%   +0.14%     
===========================================
  Files          372      368       -4     
  Lines        24297    24188     -109     
  Branches       964      940      -24     
===========================================
- Hits         16619    16579      -40     
+ Misses        7675     7609      -66     
+ Partials         3        0       -3
Impacted Files Coverage Δ
refinery/core/test_views.py 100% <ø> (ø) ⬆️
refinery/ui/source/js/provvis/ctrls/ctrl.js 33.67% <ø> (ø) ⬆️
...finery/ui/source/js/analysis-monitor/ctrls/ctrl.js 70% <ø> (ø) ⬆️
refinery/core/views.py 69.25% <100%> (ø) ⬆️
.../ui/source/js/analysis-monitor/services/factory.js 58.24% <100%> (ø) ⬆️
...ce/js/data-set-import/directives/isa-tab-import.js 100% <0%> (ø) ⬆️
...port/directives/file-upload-command-line-button.js
...mport/directives/file-upload-command-line-modal.js
...controllers/file-upload-command-line-modal-ctrl.js
...ontrollers/file-upload-command-line-button-ctrl.js
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e27363...ab1c68e. Read the comment docs.

@jkmarx jkmarx merged commit 4b3651c into develop Apr 23, 2019
@jkmarx jkmarx deleted the jkmarx/update-analysis-view-set-params branch April 29, 2019 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants