Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hiding of buttons on resize. #3340

Merged
merged 1 commit into from Apr 23, 2019
Merged

Fix hiding of buttons on resize. #3340

merged 1 commit into from Apr 23, 2019

Conversation

jkmarx
Copy link
Member

@jkmarx jkmarx commented Apr 23, 2019

Resolves #3267

@jkmarx jkmarx added this to the Release 1.6.9 milestone Apr 23, 2019
@jkmarx jkmarx self-assigned this Apr 23, 2019
@codecov
Copy link

codecov bot commented Apr 23, 2019

Codecov Report

Merging #3340 into develop will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3340      +/-   ##
===========================================
+ Coverage    68.39%   68.54%   +0.14%     
===========================================
  Files          372      368       -4     
  Lines        24297    24188     -109     
  Branches       964      940      -24     
===========================================
- Hits         16619    16579      -40     
+ Misses        7675     7609      -66     
+ Partials         3        0       -3
Impacted Files Coverage Δ
...ce/js/data-set-import/directives/isa-tab-import.js 100% <0%> (ø) ⬆️
...port/directives/file-upload-command-line-button.js
...mport/directives/file-upload-command-line-modal.js
...controllers/file-upload-command-line-modal-ctrl.js
...ontrollers/file-upload-command-line-button-ctrl.js
...e/js/data-set-import/controllers/metadata-table.js 22.27% <0%> (+0.34%) ⬆️
...e/js/data-set-import/controllers/isa-tab-import.js 46.05% <0%> (+5.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e27363...af7e29d. Read the comment docs.

@jkmarx jkmarx merged commit 2afe605 into develop Apr 23, 2019
@jkmarx jkmarx deleted the jkmarx/fix-resize-bug branch April 23, 2019 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resizing description box covers up save button
1 participant