Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide attributes related to downloading files. #3382

Merged
merged 2 commits into from May 16, 2019

Conversation

jkmarx
Copy link
Member

@jkmarx jkmarx commented May 13, 2019

Resolves #3277

  • Hide ToDo Question. is_exposed is currently used to control the table columns viewed
  • Download_url should not be a facet
  • Exclude the download and data file in the table config (they are not seen and used only to download files)

@jkmarx jkmarx self-assigned this May 13, 2019
@jkmarx jkmarx added this to the Release 1.7.0 milestone May 13, 2019
@jkmarx jkmarx added the bug label May 13, 2019
@jkmarx jkmarx requested a review from hackdna May 13, 2019 18:24
@codecov
Copy link

codecov bot commented May 13, 2019

Codecov Report

Merging #3382 into develop will decrease coverage by 0.09%.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #3382     +/-   ##
==========================================
- Coverage    68.68%   68.59%   -0.1%     
==========================================
  Files          371      371             
  Lines        24518    24259    -259     
  Branches       942      942             
==========================================
- Hits         16841    16640    -201     
+ Misses        7677     7619     -58
Impacted Files Coverage Δ
refinery/data_set_manager/models.py 83.08% <0%> (+0.37%) ⬆️
refinery/data_set_manager/views.py 63.42% <100%> (-4.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dce9416...96b9728. Read the comment docs.

@jkmarx jkmarx merged commit e7b90d0 into develop May 16, 2019
@jkmarx jkmarx deleted the jkmarx/hide-download-attribute branch May 16, 2019 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unwanted Download Facet (File Browser)
2 participants