Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jkmarx/update lodash dependency v2 #3438

Merged
merged 2 commits into from Sep 3, 2019

Conversation

jkmarx
Copy link
Member

@jkmarx jkmarx commented Sep 2, 2019

  • Update lodash to a newer version which does not have security issues.
  • Remove lodash migrate
  • Update karma library version
  • Update some lodash method usage due to array/str coercion

@jkmarx jkmarx self-assigned this Sep 2, 2019
@jkmarx jkmarx added this to the Release 1.7.1 milestone Sep 2, 2019
@codecov
Copy link

codecov bot commented Sep 2, 2019

Codecov Report

Merging #3438 into develop will decrease coverage by 0.83%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3438      +/-   ##
===========================================
- Coverage    88.32%   87.49%   -0.84%     
===========================================
  Files           84       84              
  Lines        15865    14446    -1419     
===========================================
- Hits         14013    12639    -1374     
+ Misses        1852     1807      -45
Impacted Files Coverage Δ
refinery/core/models.py 82.65% <0%> (-5.97%) ⬇️
refinery/core/views.py 69.11% <0%> (-5.77%) ⬇️
refinery/core/test_models.py 99.85% <0%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba35f44...9d952ac. Read the comment docs.

@jkmarx jkmarx merged commit 8b12cb3 into develop Sep 3, 2019
@jkmarx jkmarx deleted the jkmarx/update-lodash-dependency-v2 branch September 3, 2019 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants