Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python2 Package Updates/Changes #3464

Merged
merged 19 commits into from
Oct 21, 2019
Merged

Conversation

ilan-gold
Copy link
Member

  1. Python3 uses a different hashing method than Python2 altogether so I decided to get rid of the hash function altogether and use a reliable library
  2. Remove librabbitmq (which is Python2 only) and rely solely on ampq
  3. Add testing of the pysam module in advance of its upgrade in Python3

@codecov
Copy link

codecov bot commented Oct 10, 2019

Codecov Report

Merging #3464 into develop will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3464      +/-   ##
===========================================
- Coverage    87.45%   87.41%   -0.04%     
===========================================
  Files           97       96       -1     
  Lines        14874    14800      -74     
===========================================
- Hits         13008    12938      -70     
+ Misses        1866     1862       -4
Impacted Files Coverage Δ
refinery/file_store/utils.py 68.93% <100%> (-1.97%) ⬇️
refinery/file_store/test_utils.py 100% <100%> (ø) ⬆️
refinery/data_set_manager/tasks.py 54.49% <0%> (-3%) ⬇️
refinery/core/views.py 68.75% <0%> (-0.5%) ⬇️
refinery/data_set_manager/utils.py 81.71% <0%> (-0.15%) ⬇️
refinery/core/models.py 82.47% <0%> (ø) ⬆️
refinery/data_set_manager/test_tasks.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf46b82...8579a49. Read the comment docs.

@ilan-gold ilan-gold requested a review from jkmarx October 11, 2019 13:48
@jkmarx jkmarx requested a review from hackdna October 11, 2019 16:55
requirements.txt Outdated Show resolved Hide resolved
refinery/file_store/utils.py Outdated Show resolved Hide resolved
Copy link
Member

@hackdna hackdna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refinery/data_set_manager/test-data/test.bam is no longer needed

@ilan-gold ilan-gold merged commit bf73381 into develop Oct 21, 2019
@ilan-gold ilan-gold deleted the ilan-gold/python2_in_place_update branch October 21, 2019 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants