Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jkmarx/data set infinite scroll #987

Merged
merged 20 commits into from Mar 31, 2016
Merged

Jkmarx/data set infinite scroll #987

merged 20 commits into from Mar 31, 2016

Conversation

jkmarx
Copy link
Member

@jkmarx jkmarx commented Mar 30, 2016

This resolves #949

J.Marx added 20 commits March 22, 2016 11:01
Add ui-grid-infinite-scroll module.
98f31c5
Add node count to solr response.
64fffbb
Adjust test for new param.
9346aef
Add assayFilesTotalItems variable.
ca1fec4
Remove ui-grid footer.
8abc04d
Ui-grid implemented for scrolling down.
84afa7a
Resolve promise issue from dataLoaded.
bde30ca
Remove unused dependency.
558706d
Add ui-grid.
c2e6802
Remove direction definition. Ui-grid issue was because of tabs.
75b42f8
Update scrolling up.
c85c448
Link up ui-grid min file instead.
770dee7
Remove unused param definition.
7ea5423
For data_set2 the default is /files/browse, which prevents double gri…
dbfbbe0 
…d initializing."
Refactor getFirstData into updateAssayFiles.
071c5d3
Remove unused variables.
a8b1e0c
Remove unneccessary getPage method.
f646ad9
Refactor to angular.forEach.
9312cff
Call reset after filters and sorts are called.
76257f6
Update test with param.
4b22f12
@jkmarx jkmarx self-assigned this Mar 30, 2016
@jkmarx jkmarx added this to the Randolph milestone Mar 30, 2016
@codecov-io
Copy link

Current coverage is 22.61%

Merging #987 into develop will not affect coverage as of 492d9ac

@@            develop    #987   diff @@
=======================================
  Files           233     233       
  Stmts         18011   18091    +80
  Branches       1022    1025     +3
  Methods                           
=======================================
+ Hit            4073    4091    +18
  Partial           0       0       
- Missed        13938   14000    +62

Review entire Coverage Diff as of 492d9ac

Powered by Codecov. Updated on successful CI builds.

@jkmarx jkmarx merged commit 9b387af into develop Mar 31, 2016
@jkmarx jkmarx deleted the jkmarx/data-set-infinite-scroll branch March 31, 2016 14:17
@jkmarx jkmarx mentioned this pull request Apr 1, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jkmarx jkmarx

Labels
dataset ui
Projects
None yet
Milestone
Randolph
Development

Successfully merging this pull request may close these issues.

Implement UI-Grid Infinite Scroll
2 participants
@jkmarx @codecov-io