-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple from refinerycms-authentication-devise #446
Comments
@bricesanchez can't we access |
@bricesanchez I think we should remove the author feature and implement it as purely a string field |
I'm ok, we should rethink the author feature. I don't think it should be only a string, i use this feature with refinerycms-teams (Refinery::Team model) instead of Refinery::User. It's very useful. |
So do we disable it unless something is specified? Opt-in to feature?
|
@parndt i think yes. |
This will need to be better addressed in #446 but.. it stops the errors.
I had to make a fix so that it would boot in current applications. |
Could we depend on refinerycms-authentication-devise only to run tests ? |
@bricesanchez I don't think so.. but I have a branch where I attempt to solve this entirely: https://github.com/refinery/refinerycms-blog/compare/refinery-user-coupling |
See #449 |
What's the status on this issue? On trying to integrate Refinery with Refinery-Blog in a Spree-app using Spree's authentication system via spree-refinery-authentication instead of refinerycms-authentication-devise I was running in issue #452. Are there any preliminary workarounds I could try to get this setup running? |
@marcelotto At this time i manually create the blog initializer before running the extension generator : bricesanchez/spree-refinerycms-test@1e13ebd |
@bricesanchez Thanks, that helped. 👍 |
@parndt Should we change this line :
|
@marcelotto nice to know that there are |
A bit too early happy. When trying to create a post, it failed on the Spree::User.class_eval do
alias_attribute :username, :login
end In a @bricesanchez |
Extending
Feel free to open a pull request :) |
@bricesanchez Probably? Does it work? |
Closed in favor of #459 |
At this time we have to use Blog at least with refinerycms authentication devise gem : https://github.com/refinery/refinerycms-blog/blob/master/lib/refinery/blog/configuration.rb#L28-L35
We can't use it without an authentication system (like for development or testing).
Perhaps we should be able to disable by default the author feature?
The text was updated successfully, but these errors were encountered: