Fixed avatar_url #155
Merged
Fixed avatar_url #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…actually respects the :size option, and (3) supports a custom default image.
| size = ("?s=#{options[:size]}" if options[:size]) | ||
| "http://gravatar.com/avatar/#{Digest::MD5.hexdigest(self.email.to_s.strip.downcase)}#{size}.jpg" | ||
| params = { | ||
| s: options[:size] || 60, |
There was a problem hiding this comment.
This hash syntax will break on ruby 1.8.x and the same goes for line below.
There was a problem hiding this comment.
Ah, my bad. I'll fix and resubmit when I have a minute.
|
Look OK? I wanted to add a spec for this, but wasn't sure how to run tests. I found instructions for running specs on the main refinerycms project, but it's not clearly how to run them on its satellite projects like refinerycms-blog. Are there instructions for that lurking somewhere? |
|
The tests are much easier on rails-3-1 branch which is hopefully shipping any month now ;-) so things will get better soon. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(1) It now uses the correct Gravatar URL syntax, rather than putting a spurious ".jpg" in the query string.
(2) It actually respects the :size option.
(3) It supports Gravatar's custom default image options.