Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[reflex-web tweaks] Do not memoize children of InputGroup #2230

Merged
merged 4 commits into from
Nov 30, 2023
Merged

[reflex-web tweaks] Do not memoize children of InputGroup #2230

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
89fcf7e
Do not memoize children of InputGroup
masenf Nov 29, 2023
ee11312
test_form_submit: enrich test case with input_group and button_group
masenf Nov 29, 2023
6162539
MemoizationMode: an extensible field of Component
masenf Nov 30, 2023
d38cc89
Merge remote-tracking branch 'origin/main' into masenf/reflex-web-tweaks
masenf Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion reflex/components/component.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1643,10 +1643,11 @@ def compile_from(cls, component: BaseComponent) -> BaseComponent:
Returns:
The memoized component tree.
"""
from reflex.components.forms.input import InputGroup
from reflex.components.layout.foreach import Foreach

# Foreach must be memoized as a single component to retain index Var context.
if not isinstance(component, Foreach):
if not isinstance(component, (Foreach, InputGroup)):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update the comment here too. Do we need to add any other components to this tuple?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, maybe the ButtonGroup. I'll poke around

component.children = [
cls.compile_from(child) for child in component.children
]
Expand Down
Loading