Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[reflex-web tweaks] Do not memoize children of InputGroup #2230

Merged
merged 4 commits into from
Nov 30, 2023

Commits on Nov 29, 2023

  1. Do not memoize children of InputGroup

    The Chakra InputGroup component depends on its children being specific types of
    components, so a memoized Input_* is not "seen" as the input component.
    masenf committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    89fcf7e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ee11312 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2023

  1. MemoizationMode: an extensible field of Component

    To help handle memoization exceptions and special cases as they are discovered,
    use a field on Component which controls aspecs of the auto-memoization process.
    
    For now, only the "recursive" boolean is understood.
    
    There is certain to be future categories of exceptions to memoization that will
    be discovered, so instead of plumbing additional fields through, the
    MemoizationMode can be extended with defaults and used to handle these special
    cases in the components that need them, rather than centrally in the Component
    or StatefulComponent logic.
    
    Replace special case recursive logic for Foreach and InputGroup components with
    this new mechanism.
    masenf committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    6162539 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d38cc89 View commit details
    Browse the repository at this point in the history