[REF-2172] Add DECORATED_PAGES before compiling in thread #2841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and run with py3.8 to catch regressions
py38 and py39 cannot get asyncio.Lock() instances in a thread that has no event loop running, so if a decorated page (@rx.page) depends on state, it needs to be added to the app in the MainThread and trigger the redis connection in the that thread. Since compile_ now happens in a separate thread, reflex cannot safely add decorated pages during compile_.
picklelo
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
py38 and py39 cannot get asyncio.Lock() instances in a thread that has no event loop running, so if a decorated page (@rx.page) depends on state, it needs to be added to the app in the MainThread and trigger the redis connection in the that thread.
Since compile_ now happens in a separate thread, reflex cannot safely add decorated pages during compile_.
This PR is based on #2839 to get CI coverage for py3.8 in the integration tests. That PR will fail... and this PR will fix it!