Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF-2172] Add DECORATED_PAGES before compiling in thread #2841

Merged
merged 7 commits into from Mar 12, 2024
Merged

[REF-2172] Add DECORATED_PAGES before compiling in thread #2841

merged 7 commits into from Mar 12, 2024

Commits on Mar 12, 2024

  1. integration test compat for py38

    @masenf
    masenf committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    782d5e9 View commit details
    Browse the repository at this point in the history

  2. Fix py38 incompatibilities in vars and components

    @masenf
    masenf committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    63ac95f View commit details
    Browse the repository at this point in the history

  3. integration_app_harness.yml: test with python 3.8.10

    @masenf
    masenf committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    0bbb51a View commit details
    Browse the repository at this point in the history

  4. Use python 3.8.18 in the integration tests

    @masenf
    masenf committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    fc1ed01 View commit details
    Browse the repository at this point in the history

  5. reflex_init_in_docker_test: also run in dev and prod mode (with redis) 

    and run with py3.8 to catch regressions
    @masenf
    masenf committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    ff9f91f View commit details
    Browse the repository at this point in the history

  6. [REF-2172] Add DECORATED_PAGES before compiling in thread 

    py38 and py39 cannot get asyncio.Lock() instances in a thread that has
no event loop running, so if a decorated page (@rx.page) depends on state,
it needs to be added to the app in the MainThread and trigger the
redis connection in the that thread.

Since compile_ now happens in a separate thread, reflex cannot safely
add decorated pages during compile_.
    @masenf
    masenf committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    06d66ce View commit details
    Browse the repository at this point in the history

  7. in_docker_test_script.sh: wait a bit longer to avoid lingering ports

    @masenf
    masenf committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    f163439 View commit details
    Browse the repository at this point in the history