Windows --frontend-only fix ctrl + c
#3181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduced a workaround(#2954) to fix the
ctrl + cbug in windows affecting uvicorn which causes the frontend to exit on hot reload. This fix applied to the case of running the frontend and backend concurrently, however another issue was introduced wherectrl + cdoes not work at all when running the frontend only. This PR makes sure the frontend is created as a subprocess group independent of its parent ONLY when the backend exists. This should keep the frontend process in the same group as the parent process and allow SIGINT reach.