[REF-2523] Implement new public Component API #3203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add_imports (dict str: list of str or importvar) add_hooks (list of str) add_custom_code (list of str) These functions are treated specially in that they don't have to call `super()`, ever. Internally the Component will walk up all of the base Component classes and call each `add_*` method and collect the return values. All the downstream user has to do is implement these add_* functions and return the value they want to add.
picklelo
previously approved these changes
May 1, 2024
| return {} | ||
|
|
||
| def add_hooks(self) -> list[str]: | ||
| """Add hooks inside the component function. |
There was a problem hiding this comment.
Maybe this can include an example of how it's used in practice (along with the other ones) for the autogenerated API docs
| @@ -932,6 +989,30 @@ def _has_event_triggers(self) -> bool: | |||
| return True | |||
| return False | |||
|
|
|||
| @classmethod | |||
| def _iter_parent_classes_with_method(cls, method: str) -> Iterator[Type[Component]]: | |||
There was a problem hiding this comment.
Does this affect compile time noticeably at all?
There was a problem hiding this comment.
on reflex-web, there is no change in compile time 😅, i expect this iter operation to be quite fast; although it does have to look at all parent classes in the mro chain, it doesn't actually call the method unless it's been defined, and it only calls each unique method once.
picklelo
previously approved these changes
May 1, 2024
picklelo
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add_imports (dict str: list of str or importvar)
add_hooks (list of str)
add_custom_code (list of str)
These functions are treated specially in that they don't have to call
super(), ever. Internally the Component will walk up all of the base Component classes and call eachadd_*method and collect the return values.All the downstream user has to do is implement these add_* functions and return the value they want to add.