Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add distributeListOverDynPure, export distributeMapOverDynPure #70

Merged
merged 1 commit into from Oct 18, 2016
Merged

Add distributeListOverDynPure, export distributeMapOverDynPure #70

merged 1 commit into from Oct 18, 2016

Conversation

spl
Copy link
Contributor

@spl spl commented Oct 18, 2016

I've found distributeListOverDynPure to be a very useful function that is non-trivial to write. I think it would be a good addition to distributeDMapOverDynPure and distributeMapOverDynPure. The latter was not exported and documented strangely (possibly a copy-paste error), so I exported it and updated the documentation.

@mightybyte
Copy link
Member

👍 I always wondered why we only had the DMap version of this!

@ryantrinkle ryantrinkle merged commit 32c726a into reflex-frp:develop Oct 18, 2016
@ryantrinkle
Copy link
Member

Thanks!

@spl spl deleted the distribute-list-over-dynamic branch October 18, 2016 14:24
@lingnand
Copy link

What's the difference between distributeListOverDyn in Reflex.Class vs distributeListOverDynPure in Reflex.Dynamic? (from what I see, there's no difference)

The Pure suffix seems a bit awkward given the already long name. I'd suggest change the name of distributeMapOverDynPure to just distributeMapOverDyn and move it into Reflex.Class; then all distribute functions will be in one place.

@ryantrinkle
Copy link
Member

Good point! In general, the functions with 'Pure' in their name are ones that originally had a monadic version, and I am doing a deprecation cycle to get rid of the monadic version - so the Pure version is simply the non-Pure version, minus an invocation of return. However, in this case, I think there's no actual deprecation cycle needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants