-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve references upload flow #179
Conversation
- adopt react dnd
Codecov Report
@@ Coverage Diff @@
## main #179 +/- ##
===========================================
+ Coverage 65.19% 85.74% +20.54%
===========================================
Files 84 11 -73
Lines 4132 435 -3697
Branches 305 0 -305
===========================================
- Hits 2694 373 -2321
+ Misses 1417 62 -1355
+ Partials 21 0 -21 see 72 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Nice! This PR definitely improves #118. Eventually we might want to do some kind of file type detection as I am able to drag any kind of file onto the app and get the upload behavior which is probably not the best user experience. This PR does not address the first part of #173:
In this PR, the text For the ingestion status bar, if it's hard to communicate percent complete, I'm fine with just show that we're busy someplace. I guess we're going to have to figure out how to handle user actions that are taken while we are busing with the ingestion process. We certainly don't want to block the whole app, but perhaps we want to block new uploads until the previous uploads finish? |
Sure. That's fixed.
My idea, for the MVP, was that they would see this information when the references list is empty. So they will learn how to upload (click or drag-drop). I agree that we should add a menu entry for
Yes, the idea was to show that we are busy. The %age isn't even working as we don't have that information (we will have after #178).
Sure. I decided that for now we won't block them from upload/ingest concurrently but def improve this after that backend part is improved. Also, for the "busy indicator" maybe we should build a fixed bottom bar like VS Code has for loading indicators. |
This PR adds a new way to upload PDF files into RefStudio.
Now files are added using a drag-and-drop action to anywhere in the app, of using a explicit file browsing action in the references library panel. When a drag operation is ongoing a screen is shown with an indication (for debug) of the files being uploaded.
Features
references.PDF.upload.mov
NOTE: This PR is still missing additional unit tests for the features implemented.