Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent infinite rerendering in reference view #184

Merged
merged 2 commits into from
Jun 22, 2023
Merged

fix: prevent infinite rerendering in reference view #184

merged 2 commits into from
Jun 22, 2023

Conversation

sehyod
Copy link
Collaborator

@sehyod sehyod commented Jun 22, 2023

Fixes #183
This adds useMemo to memoize reference atom and prevent the infinite render loop
This also removes a duplicated key, that was triggering a warning message

@sehyod sehyod added the bug Something isn't working label Jun 22, 2023
@cguedes cguedes merged commit 1527212 into main Jun 22, 2023
9 checks passed
@cguedes cguedes deleted the infinite-render branch June 22, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cguedes cguedes cguedes approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reference view provoke infinite rerendering
2 participants
@sehyod @cguedes