-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update ingest so uploads are only processed once #219
feat: Update ingest so uploads are only processed once #219
Conversation
Codecov Report
@@ Coverage Diff @@
## main #219 +/- ##
==========================================
+ Coverage 72.18% 72.42% +0.24%
==========================================
Files 103 103
Lines 5069 5125 +56
Branches 405 405
==========================================
+ Hits 3659 3712 +53
- Misses 1392 1395 +3
Partials 18 18
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how feasible that is, but it would be great to have a test checking that when _load_references
returns a reference, the reference is excluded from the ingestion process
@sehyod can you say more about this? As implemented, we exclude any references from Are you saying you'd like a test for the |
Yes, I meant adding a test to make sure references that were loaded via |
fixes #218
Note that
IngestResponse
will still contain all References, not just the newly uploaded Reference. Let me know if we want to change this.