Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: menu shortcuts for web #388

Merged
merged 6 commits into from
Aug 23, 2023
Merged

feat: menu shortcuts for web #388

merged 6 commits into from
Aug 23, 2023

Conversation

cguedes
Copy link
Collaborator

@cguedes cguedes commented Aug 21, 2023

Closes #387 and related to #347

This PR adds menu actions to the command palette and shortcut handlers for menu actions.
Also stop event propagation for existing commands to prevent tab switch in the web for example (cmd+1, ...).

image

…ions to command palette

- also stop propagation and default for some shortcuts (ex: cmd+1, cmd+2)
@cguedes cguedes changed the title 347 menu shortcuts for web feat: menu shortcuts for web Aug 21, 2023
@cguedes cguedes requested a review from sehyod August 21, 2023 15:20
@cguedes cguedes marked this pull request as ready for review August 21, 2023 15:20
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #388 (e638cf2) into main (e06f8cd) will increase coverage by 2.90%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #388      +/-   ##
==========================================
+ Coverage   83.25%   86.15%   +2.90%     
==========================================
  Files         178       17     -161     
  Lines       10282     1040    -9242     
  Branches     1108        0    -1108     
==========================================
- Hits         8560      896    -7664     
+ Misses       1708      144    -1564     
+ Partials       14        0      -14     

see 161 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

src/application/App.tsx Outdated Show resolved Hide resolved
src/application/WebMenuShortcuts.tsx Outdated Show resolved Hide resolved
src/application/WebMenuShortcuts.tsx Outdated Show resolved Hide resolved
@cguedes cguedes marked this pull request as draft August 22, 2023 08:38
@cguedes cguedes changed the title feat: menu shortcuts for web feat: menu shortcuts for web 🚧 Aug 22, 2023
@cguedes cguedes changed the title feat: menu shortcuts for web 🚧 🚧 feat: menu shortcuts for web Aug 23, 2023
@cguedes cguedes changed the title 🚧 feat: menu shortcuts for web feat: menu shortcuts for web Aug 23, 2023
@cguedes cguedes marked this pull request as ready for review August 23, 2023 09:26
@cguedes cguedes requested a review from sehyod August 23, 2023 09:29
@cguedes cguedes merged commit 1f19ffd into main Aug 23, 2023
10 checks passed
@cguedes cguedes deleted the 347-menu_shortcuts_for_web branch August 23, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Menu shortcut action available on the web version
2 participants