-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: menu shortcuts for web #388
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions to command palette - also stop propagation and default for some shortcuts (ex: cmd+1, cmd+2)
Codecov Report
@@ Coverage Diff @@
## main #388 +/- ##
==========================================
+ Coverage 83.25% 86.15% +2.90%
==========================================
Files 178 17 -161
Lines 10282 1040 -9242
Branches 1108 0 -1108
==========================================
- Hits 8560 896 -7664
+ Misses 1708 144 -1564
+ Partials 14 0 -14 see 161 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sehyod
reviewed
Aug 21, 2023
- handle - refstudio event also, with option to only work for the web version
sehyod
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #387 and related to #347
This PR adds menu actions to the command palette and shortcut handlers for menu actions.
Also stop event propagation for existing commands to prevent tab switch in the web for example (cmd+1, ...).