Export references #392
Merged
Export references #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 22, 2023 14:56
Codecov Report
@@ Coverage Diff @@
## main #392 +/- ##
==========================================
- Coverage 84.16% 83.72% -0.45%
==========================================
Files 175 159 -16
Lines 10016 9149 -867
Branches 1101 1103 +2
==========================================
- Hits 8430 7660 -770
+ Misses 1575 1478 -97
Partials 11 11
... and 16 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cguedes
reviewed
Aug 22, 2023
| @@ -335,6 +337,31 @@ export async function renameFile(relativePath: string, newName: string): RenameF | |||
| } | |||
| type RenameFileResult = Promise<{ success: false } | { success: true; newPath: string }>; | |||
|
|
|||
| export async function exportReferences(references: ReferenceItem[]) { | |||
There was a problem hiding this comment.
nit: you need to add this to the __mocks__/filesystem.ts
cguedes
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the function to exports the entire list of references as a .bib file. Clicking on the button opens a dialog to choose where the file should be saved (defaulting to the
exportsfolder of the project)When no reference has been ingested, the button is disabled
Closes #345