Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create python http equivalent of settingsManager.ts #396

Merged
merged 5 commits into from
Aug 24, 2023

Conversation

gjreda
Copy link
Collaborator

@gjreda gjreda commented Aug 22, 2023

fixes #364


I think this generic API for settings should be all we need, but let me know otherwise @cguedes @danvk

@gjreda gjreda changed the title Create python http equivalent of settingsManager.ts feat: Create python http equivalent of settingsManager.ts Aug 22, 2023
@gjreda gjreda marked this pull request as ready for review August 22, 2023 22:55
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #396 (e239f73) into main (1c15395) will decrease coverage by 0.25%.
Report is 4 commits behind head on main.
The diff coverage is 98.21%.

@@            Coverage Diff             @@
##             main     #396      +/-   ##
==========================================
- Coverage   83.25%   83.00%   -0.25%     
==========================================
  Files         178      180       +2     
  Lines       10282    10462     +180     
  Branches     1108     1114       +6     
==========================================
+ Hits         8560     8684     +124     
- Misses       1708     1763      +55     
- Partials       14       15       +1     
Files Changed Coverage Δ
python/sidecar/settings.py 97.77% <96.55%> (-2.23%) ⬇️
python/sidecar/http.py 85.83% <100.00%> (+1.14%) ⬆️
python/sidecar/typing.py 97.53% <100.00%> (+0.27%) ⬆️
python/web.py 100.00% <100.00%> (ø)

... and 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

python/sidecar/settings.py Outdated Show resolved Hide resolved
python/sidecar/http.py Outdated Show resolved Hide resolved
python/sidecar/typing.py Outdated Show resolved Hide resolved
@gjreda gjreda requested review from cguedes and danvk August 23, 2023 18:22
@cguedes cguedes merged commit fa6220d into main Aug 24, 2023
10 of 11 checks passed
@cguedes cguedes deleted the 364-create-pythonhttp-equivalent-of-settingsmanagerts branch August 24, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Python/HTTP equivalent of settingsManager.ts
2 participants