feat: Implement design for settings modal #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #479 +/- ##
==========================================
+ Coverage 80.22% 80.41% +0.18%
==========================================
Files 195 198 +3
Lines 11660 11834 +174
Branches 1115 1137 +22
==========================================
+ Hits 9354 9516 +162
- Misses 2290 2302 +12
Partials 16 16
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cguedes
reviewed
Sep 4, 2023
cguedes
approved these changes
Sep 4, 2023
| <div id="chat-tooltip"> | ||
| <InfoIcon /> | ||
| </div> | ||
| {/* TODO: <Tooltip anchorSelect="#chat-tooltip" /> */} |
There was a problem hiding this comment.
Should this block the merge?
There was a problem hiding this comment.
I think it's fine, I'll create a ticket to update the tooltip. The design team is aware of that and is working on the tooltip design and content
cguedes
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements useful components (Checkbox, Input, ...) and the updated design for the Settings Modal.
The modal can now be closed by clicking outside of it or pressing Escape
Closes #438