Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Stop using the project path in the client code #513

Merged
merged 2 commits into from
Sep 7, 2023

Conversation

cguedes
Copy link
Collaborator

@cguedes cguedes commented Sep 7, 2023

This closes #504

@cguedes cguedes linked an issue Sep 7, 2023 that may be closed by this pull request
@cguedes cguedes requested a review from sehyod September 7, 2023 10:06
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #513 (548e536) into main (28e9047) will decrease coverage by 0.44%.
The diff coverage is 36.66%.

@@            Coverage Diff             @@
##             main     #513      +/-   ##
==========================================
- Coverage   81.68%   81.24%   -0.44%     
==========================================
  Files         213      183      -30     
  Lines       12109    10786    -1323     
  Branches     1181     1179       -2     
==========================================
- Hits         9891     8763    -1128     
+ Misses       2204     2009     -195     
  Partials       14       14              
Files Changed Coverage Δ
src/AppStartup.tsx 92.95% <0.00%> (ø)
src/application/listeners/projectEventListeners.ts 48.17% <0.00%> (ø)
src/components/footer/Footer.tsx 100.00% <ø> (ø)
src/atoms/projectState.ts 84.37% <25.00%> (-0.35%) ⬇️
src/api/projectsAPI.ts 37.93% <57.14%> (+2.74%) ⬆️

... and 30 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cguedes cguedes merged commit df40d2b into main Sep 7, 2023
10 checks passed
@cguedes cguedes deleted the 504-stop-using-the-project_path-in-the-client-code branch September 7, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop using the project_path in the client code
2 participants